Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests #8

Merged
merged 6 commits into from
Mar 8, 2024
Merged

Add tests #8

merged 6 commits into from
Mar 8, 2024

Conversation

asbiin
Copy link
Contributor

@asbiin asbiin commented Mar 5, 2024

@zepfietje Would you accept some tests?

@zepfietje
Copy link
Collaborator

Sure, @asbiin!

Is this ready for review?

@asbiin
Copy link
Contributor Author

asbiin commented Mar 7, 2024

Is this ready for review?

yes!

tests/PirschTest.php Outdated Show resolved Hide resolved
tests/PirschTest.php Outdated Show resolved Hide resolved
tests/TrackPageviewTest.php Outdated Show resolved Hide resolved
@zepfietje
Copy link
Collaborator

Thanks, @asbiin!

@zepfietje zepfietje merged commit de4d703 into pirsch-analytics:master Mar 8, 2024
27 checks passed
@asbiin asbiin deleted the tests01 branch March 8, 2024 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants